Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Android 5 #121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support Android 5 #121

wants to merge 1 commit into from

Conversation

fynngodau
Copy link

@fynngodau fynngodau commented Mar 2, 2021

As described in #114, CCTG supports Android 5, so it would be nice if this app would as well.

The only issue was a that the color ?android:attr/colorBackgroundFloating was only added with API level 23, so I tried to find a similar color resource. I chose ?android:attr/colorForegroundInverse because it is white (#FFFFFF) for light theme, black for dark theme – though actually a bit too dark then, as the original color resource value was lighter than the background. This means that this PR also changes the background color of cards in the exposure details view.

I could not test the root extraction process lacking a real Android 5 device, but the Correctness linter shows no warnings about incompatible code so I don't expect any crashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant